-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add button disable on submit for login grant #33166
Conversation
@Lukasdoe we'll need a signoff on the commit as well, please refer to these steps on how to do that |
Commit is signed-off. |
This comment was marked as outdated.
This comment was marked as outdated.
@Pytal is there anything else I can do? |
@Lukasdoe yes, could you rebase, compile and force push ? :) Something like: git rebase origin/master
npm ci
npm run build
git commit --amend
git push --force |
Signed-off-by: Lukas Döllerer <info@lukas-doellerer.de>
Done. Build now failing, though. However, I guess that's not because of my change :) |
@Lukasdoe does the build still fail after syncing your fork first with the commands below? git remote add upstream https://github.com/nextcloud/server.git
git pull --rebase upstream master
npm ci
npm run build
git commit --amend
git push --force |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only see unrelated failing CI, looks good to me :)
These are the exact steps I executed before the last force push^^ |
CI failure unrelated |
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
Thanks for the PR @Lukasdoe ! |
Fixes #33164