Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button disable on submit for login grant #33166

Merged
merged 1 commit into from
Jul 26, 2022
Merged

Add button disable on submit for login grant #33166

merged 1 commit into from
Jul 26, 2022

Conversation

Lukasdoe
Copy link
Contributor

@Lukasdoe Lukasdoe commented Jul 7, 2022

Fixes #33164

@CarlSchwan CarlSchwan requested review from a team, PVince81, Pytal and szaimen and removed request for a team July 8, 2022 09:14
@CarlSchwan CarlSchwan added the 3. to review Waiting for reviews label Jul 8, 2022
@CarlSchwan CarlSchwan added this to the Nextcloud 25 milestone Jul 8, 2022
@Pytal
Copy link
Member

Pytal commented Jul 8, 2022

@Lukasdoe we'll need a signoff on the commit as well, please refer to these steps on how to do that

@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 8, 2022
@Lukasdoe
Copy link
Contributor Author

Commit is signed-off.

@Pytal

This comment was marked as outdated.

@Lukasdoe
Copy link
Contributor Author

@Pytal is there anything else I can do?

@artonge
Copy link
Contributor

artonge commented Jul 25, 2022

@Lukasdoe yes, could you rebase, compile and force push ? :)

Something like:

git rebase origin/master
npm ci
npm run build
git commit --amend
git push --force

Signed-off-by: Lukas Döllerer <info@lukas-doellerer.de>
@Lukasdoe
Copy link
Contributor Author

Done. Build now failing, though. However, I guess that's not because of my change :)

@Pytal
Copy link
Member

Pytal commented Jul 25, 2022

@Lukasdoe does the build still fail after syncing your fork first with the commands below?

git remote add upstream https://github.com/nextcloud/server.git
git pull --rebase upstream master
npm ci
npm run build
git commit --amend
git push --force

Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only see unrelated failing CI, looks good to me :)

@Lukasdoe
Copy link
Contributor Author

@Lukasdoe does the build still fail after syncing your fork first with the commands below?

git remote add upstream https://github.com/nextcloud/server.git
git pull --rebase upstream master
npm ci
npm run build
git commit --amend
git push --force

These are the exact steps I executed before the last force push^^

@szaimen
Copy link
Contributor

szaimen commented Jul 26, 2022

CI failure unrelated

@szaimen szaimen merged commit 9f77aba into nextcloud:master Jul 26, 2022
@welcome
Copy link

welcome bot commented Jul 26, 2022

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@artonge
Copy link
Contributor

artonge commented Jul 26, 2022

Thanks for the PR @Lukasdoe !

@skjnldsv skjnldsv mentioned this pull request Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: OAuth login flow allows users to submit multiple times
6 participants