RFC: Support password-less public key token #32624
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idea is that we would add a mode in which Nextcloud doesn't stores encrypted user password in the database. This would be opt-in and disable some Nextcloud features (e.g. external storages) Todos: - Replace true condition with system config Test plan: - Login in webui and desktop client - Apply this patch - User is still logged in in both webui and desktop client Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
commented
May 27, 2022
| $dbToken->setPublicKey($publicKey); | ||
| $dbToken->setPrivateKey($this->encrypt($privateKey, $token)); | ||
| $dbToken->setPublicKey($publicKey); | ||
| $dbToken->setPrivateKey($this->encrypt($privateKey, $token)); |
There was a problem hiding this comment.
TODO does it make sense to not store the private key and public anymore if we don't store the passwords?
|
I merged another PR that does implement it |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is that we would add a mode in which Nextcloud doesn't stores
encrypted user password in the database. This would be opt-in and
disable some Nextcloud features (e.g. external storages)
Todos:
Test plan: