Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable23] Explicitly close div element #32417

Merged
merged 1 commit into from
May 16, 2022
Merged

Conversation

artonge
Copy link
Contributor

@artonge artonge commented May 16, 2022

Manual backport of #31820

This will allow us to bump jQuery

@artonge artonge added 3. to review Waiting for reviews technical debt labels May 16, 2022
@artonge artonge added this to the Nextcloud 23.0.5 milestone May 16, 2022
@artonge artonge self-assigned this May 16, 2022
@artonge artonge requested review from a team, PVince81, skjnldsv and szaimen and removed request for a team May 16, 2022 10:17
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, didn't test

@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 16, 2022
@blizzz
Copy link
Member

blizzz commented May 16, 2022

conflicts

@blizzz blizzz added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels May 16, 2022
@blizzz blizzz mentioned this pull request May 16, 2022
@artonge artonge force-pushed the backport/stable23/fix/30002 branch from bb5104d to 6f46987 Compare May 16, 2022 12:01
Fix: #30002
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the backport/stable23/fix/30002 branch from 6f46987 to a620828 Compare May 16, 2022 18:45
@blizzz
Copy link
Member

blizzz commented May 16, 2022

failing test unrelated

@blizzz blizzz merged commit 4062c52 into stable23 May 16, 2022
@blizzz blizzz deleted the backport/stable23/fix/30002 branch May 16, 2022 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants