Fix sync errors for card creation with the same uri from different sources

[miaulalala]

When syncing the system address book,, the email address is used as the uri.

This leads to errors when two different backends are providing the same email addresses and try to create VCards for those entries separately.

Since the code should not be forced to decide which data providing backend is the source of truth, the uri should include the backend identifier to make uris more unique and dependent on their source.

[miaulalala]

@skjnldsv could you check this branch out and re- test it on your setup please?

[miaulalala]

/rebase

[miaulalala]

This integration test fails:

  Scenario: users can not be searched by id
    Given user "user0" exists
    And user "user1" exists
    And As an "admin"
    And sending "PUT" to "/cloud/users/user1" with
      | key | displayname |
      | value | Test name |
    When Logging in using web as "user0"
    And searching for contacts matching with "user"
    Then the list of searched contacts has "0" contacts

@ChristophWurst do you know how to fix this? I have never written tests like these before

[miaulalala]

/rebase

[miaulalala]

This integration test fails:

  Scenario: users can not be searched by id
    Given user "user0" exists
    And user "user1" exists
    And As an "admin"
    And sending "PUT" to "/cloud/users/user1" with
      | key | displayname |
      | value | Test name |
    When Logging in using web as "user0"
    And searching for contacts matching with "user"
    Then the list of searched contacts has "0" contacts

The UID is matching for the backend - search term "user" and uid "users:foo-baz-bar"

Since the VCard rfc doesn't explicitly specify a format, I will md5 hash the composite uid value to obscure the backend name for the search. this doesn't need to be cryptographically safe.

[miaulalala]

/rebase

[miaulalala]

Drone failure unrelated:

There was 1 failure:
--
655 |  
656 | 1) OCA\Settings\Tests\Controller\CheckSetupControllerTest::testCheck
657 | Failed asserting that two objects are equal.

[nickvergessen]

Drone failure unrelated:

However this is not unrelated:

> integration-contacts-menu

--- Failed scenarios:
    /drone/src/build/integration/features/contacts-menu.feature:27

[nickvergessen]

Also this is a breaking change for OCP\Contacts\ContactsMenu\IProvider that read \OCP\Contacts\ContactsMenu\IEntry::getProperty('UID')

[nickvergessen]

Restored the original content (userid) of \OCP\Contacts\ContactsMenu\IEntry::getProperty('UID') via #36110

[nickvergessen]

Reverted in #36131

Also the sync service assumed the UID is the user id:

server/apps/dav/lib/CardDAV/SyncService.php

Lines 273 to 282 in e6f4705

	// remove no longer existing
	$allCards = $this->backend->getCards($systemAddressBook['id']);
	foreach ($allCards as $card) {
	$vCard = Reader::read($card['carddata']);
	$uid = $vCard->UID->getValue();
	// load backend and see if user exists
	if (!$this->userManager->userExists($uid)) {
	$this->deleteUser($card['uri']);
	}
	}