Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Migrators id instead of class names #31925

Merged
merged 2 commits into from
Apr 11, 2022

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Apr 11, 2022

This will help with UI and means migrators can move in namespaces
without changing export format.

Signed-off-by: Côme Chilliet come.chilliet@nextcloud.com

@come-nc come-nc added the 3. to review Waiting for reviews label Apr 11, 2022
@come-nc come-nc added this to the Nextcloud 24 milestone Apr 11, 2022
@come-nc come-nc requested a review from Pytal April 11, 2022 08:55
@come-nc come-nc self-assigned this Apr 11, 2022
@come-nc come-nc requested review from PVince81, a team, blizzz and juliushaertl and removed request for a team April 11, 2022 08:55
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@come-nc
Copy link
Contributor Author

come-nc commented Apr 11, 2022

/rebase

This will help with UI and means migrators can move in namespaces
 without changing export format.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@nextcloud-command nextcloud-command force-pushed the fix/user_migration-use-id-for-migrators branch from 7243f48 to eed6330 Compare April 11, 2022 13:59
@come-nc come-nc merged commit 2c04711 into master Apr 11, 2022
@come-nc come-nc deleted the fix/user_migration-use-id-for-migrators branch April 11, 2022 14:57
@come-nc
Copy link
Contributor Author

come-nc commented Apr 11, 2022

(failure unrelated)

@blizzz blizzz mentioned this pull request Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants