Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix accept/reject remote share action #31301 #31910

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Fix accept/reject remote share action #31301 #31910

merged 1 commit into from
Apr 12, 2022

Conversation

MSe1969
Copy link
Contributor

@MSe1969 MSe1969 commented Apr 8, 2022

This is the fix for the described problem in
#31301

@szaimen szaimen added bug 3. to review Waiting for reviews labels Apr 8, 2022
@szaimen szaimen added this to the Nextcloud 24 milestone Apr 8, 2022
@szaimen
Copy link
Contributor

szaimen commented Apr 8, 2022

@MSe1969 thanks for fixing this!

Can you please solve DCO? Thank you! :)

@MSe1969
Copy link
Contributor Author

MSe1969 commented Apr 8, 2022 •
edited
Loading

@MSe1969 thanks for fixing this!

Can you please solve DCO? Thank you! :)

Done.

@szaimen
Copy link
Contributor

szaimen commented Apr 8, 2022

Thank you! :)

@szaimen szaimen requested review from nickvergessen, a team, PVince81, artonge and Pytal and removed request for a team April 8, 2022 21:23
@nickvergessen nickvergessen removed their request for review April 8, 2022 21:26
@szaimen
Copy link
Contributor

szaimen commented Apr 12, 2022

Looks good to me :)
@MSe1969 can you please rebase, compile the js and push it to this branch? Then CI should be green :)

szaimen
szaimen approved these changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me but didn't test

@MSe1969
Copy link
Contributor Author

MSe1969 commented Apr 12, 2022

Question:
As this would also apply to the current stable version 23 - will you centrally take care about that or do I need to also make the same PR against the stable23 branch?

@szaimen
Copy link
Contributor

szaimen commented Apr 12, 2022

Question: As this would also apply to the current stable version 23 - will you centrally take care about that or do I need to also make the same PR against the stable23 branch?

we can use the backport bot to do this after it got merged :)

@MSe1969 @szaimen
Fix accept/reject remote share action
8a6bfcb 
This is the fix for the described problem in
#31301

Signed-off-by: MSe1969 <mse1969@posteo.de>
@szaimen szaimen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 12, 2022
@szaimen
Copy link
Contributor

szaimen commented Apr 12, 2022

Failure is unrelated

@szaimen szaimen merged commit df14579 into nextcloud:master Apr 12, 2022
@welcome
Copy link

welcome bot commented Apr 12, 2022

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@szaimen
Copy link
Contributor

szaimen commented Apr 12, 2022

/backport to stable23

@backportbot-nextcloud
Copy link

The backport to stable23 failed. Please do this backport manually.

@szaimen szaimen mentioned this pull request Apr 12, 2022
Merged
@szaimen
Copy link
Contributor

szaimen commented Apr 12, 2022

#31949

This was referenced Apr 13, 2022
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@Pytal Pytal Pytal approved these changes

@szaimen szaimen szaimen approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@artonge artonge Awaiting requested review from artonge

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Milestone
Nextcloud 24
Development

Successfully merging this pull request may close these issues.
5 participants
@MSe1969 @szaimen @nickvergessen @Pytal @skjnldsv