Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the file information is available when sending the email #3181

Merged
merged 1 commit into from
Feb 10, 2017

Conversation

nickvergessen
Copy link
Member

Fix nextcloud/activity#108

@Huster-at-github can you test this? Would be awesome.
Note: it only works for new actions. Already triggered action can not be adjusted.

Steps

  1. Un-/Favorite a file and select to receive emails for it.
  2. Send the email by running cron (change activity_mq.amq_latest_send and jobs.last_run and jobs.last_checked for cheating)
  3. See the email

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member Author

@schiessle @LukasReschke please review this easy thing ;)

@Huster-at-github
Copy link

Huster-at-github commented Jan 23, 2017

Don't know what to do:

  • Marked a new file as favorite
  • Run cron.php as user www-data
  • 1,5 hours later got this e-mail:

Du hast zu deinen Favoriten hinzugefügt - Heute um 21:59:11

@nickvergessen
Copy link
Member Author

@MorrisJobke @rullzer easy to test ;)

@MorrisJobke
Copy link
Member

I only can confirm that the body is not complete:

Sie haben zu Ihren Favoriten hinzugefügt (Heute um 20:03)

@nickvergessen
Copy link
Member Author

Works here:

- You added test.txt;rm -rf test to your favorites (Today at 2:46 PM)
- You added whitepaper.odt to your favorites (Today at 2:46 PM)
- You added test to your favorites (Today at 2:46 PM)
- You removed test from your favorites (Today at 2:46 PM)
- You added test to your favorites (Today at 2:46 PM)

Also tested german:

- Sie haben test aus Ihren Favoriten entfernt (Heute um 14:47)
- Sie haben test.txt;rm -rf test aus Ihren Favoriten entfernt (Heute um 14:47)
- Sie haben whitepaper.odt aus Ihren Favoriten entfernt (Heute um 14:47)
- Sie haben test zu Ihren Favoriten hinzugefügt (Heute um 14:47)

@MorrisJobke since it fails for you, can you step in with the debugger?

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works now here. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants