Emojihelper interface #31703
Merged
Emojihelper interface #31703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nickvergessen
commented
Mar 24, 2022
•
nickvergessen
commented
- Based on Allow reactions also with other combined emojis 🧑🏾💻 #31700
- Decision if we do this before 24 or only for 25
nickvergessen
added
3. to review
nickvergessen
force-pushed
the
techdebt/noid/emojihelper-interface
branch
2 times, most recently
from
6ce8ae4 to
320f0a7
Compare
nickvergessen
force-pushed
the
techdebt/noid/emojihelper-interface
branch
3 times, most recently
from
6236991 to
0059c1b
Compare
nickvergessen
requested review from
vitormattos,
danxuliu,
a team,
PVince81,
juliusknorr and
CarlSchwan
and removed request for
a team
CarlSchwan
approved these changes
Apr 28, 2022
|
Ihmo only 25 |
|
Yeah pull request is some long time old :D |
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Vitor Mattos <vitor@php.rio>
vitormattos
force-pushed
the
techdebt/noid/emojihelper-interface
branch
from
0059c1b to
68a529a
Compare
vitormattos
force-pushed
the
techdebt/noid/emojihelper-interface
branch
from
8fd169b to
a75a22f
Compare
|
Reverted the last commits to maintain this PR only to add the interface. |
vitormattos
approved these changes
Apr 28, 2022
juliusknorr
approved these changes
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.