-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes the undefined index error with the DAV property getlastmodified #31632
Conversation
Signed-off-by: Max Kunzelmann <maxdev@posteo.de>
|
Somehow I missed that typo yesterday night. Now it should get the proper modified time. |
…ist. Signed-off-by: Max Kunzelmann <maxdev@posteo.de>
Signed-off-by: Max Kunzelmann <maxdev@posteo.de>
43b21aa
to
2952c7d
Compare
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
Thanks for the fix @Maaxxs ! |
Should this be backported? |
This PR fixes the undefined index {DAV:}getlastmodified error, which can occur in the
DAV.php
file.The return value in the else clause is false if neither
getetag
norgetlastmodified
is set. At least, I would argue that it should return false because false is returned if there is no response ($response === false
), and in the exceptions, too.It resolves some errors from issue #15363.