Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add trashbin migrator to export and import trashbin data #31575

Merged
merged 5 commits into from
Mar 29, 2022
Merged

Add trashbin migrator to export and import trashbin data #31575

merged 5 commits into from
Mar 29, 2022

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Mar 15, 2022

Signed-off-by: Côme Chilliet come.chilliet@nextcloud.com

@come-nc come-nc added this to the Nextcloud 24 milestone Mar 15, 2022
@come-nc come-nc self-assigned this Mar 15, 2022
@come-nc come-nc force-pushed the enh/add-trashbin-migrator branch from 863fb58 to 9b7b845 Compare March 15, 2022 15:22
@come-nc come-nc requested review from Pytal, a team, PVince81, skjnldsv and CarlSchwan and removed request for a team March 15, 2022 17:11
@come-nc come-nc added the 3. to review Waiting for reviews label Mar 15, 2022
@come-nc
Add trashbin migrator to export and import trashbin data
51d2289 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc force-pushed the enh/add-trashbin-migrator branch from 9b7b845 to 51d2289 Compare March 17, 2022 13:46
come-nc added 2 commits March 17, 2022 14:49
@come-nc
Rename $insert var to $qb
865ac4b 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Rename PATH constants to show if folder or file
53c731d 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Pytal
Pytal approved these changes Mar 22, 2022
View reviewed changes
Copy link
Member

@Pytal Pytal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the small comment

apps/files_trashbin/lib/UserMigration/TrashbinMigrator.php Outdated Show resolved Hide resolved
@come-nc
Improve wording of output for trashbin migrator
ecbcfca 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@skjnldsv skjnldsv mentioned this pull request Mar 24, 2022
Merged
@come-nc
Copy link
Contributor Author

come-nc commented Mar 24, 2022 •
edited
Loading

  • Should be tested with groupfolders

@come-nc
Add a guard to check that trashbin folder is a folder
7fa8b2e 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc merged commit b984cd1 into master Mar 29, 2022
@come-nc come-nc deleted the enh/add-trashbin-migrator branch March 29, 2022 12:39
@blizzz blizzz mentioned this pull request Mar 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pytal Pytal Pytal approved these changes

@artonge artonge artonge approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

Assignees

@come-nc come-nc

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 24
Development

Successfully merging this pull request may close these issues.
3 participants
@come-nc @artonge @Pytal