Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more than 1000 entries in queries exception in CardDavBackend #31274

Merged
merged 2 commits into from
Mar 11, 2022

Conversation

CarlSchwan
Copy link
Member

@CarlSchwan CarlSchwan commented Feb 19, 2022

Fix the following backtrace:

{"reqId":"------------------","level":0,"time":"-------------------","remoteAddr":"--------------","user":"-----------------------","app":"user_ldap","method":"GET","ur
l":"/apps/circles/v1/globalsearch?search=m&order=4","message":"Ready for a paged search","userAgent":"Mozilla/5.0 ---------------- ","version":"20.0.14.4"}
{"reqId":"------------------","level":3,"time":"-------------------","remoteAddr":"--------------3","user":"---------------","app":"core","method":"GET","url":"/
apps/circles/v1/globalsearch?search=m&order=4","message":{"Exception":"Doctrine\\DBAL\\Query\\QueryException","Message":"More than 1000 expressions in a list are not allowed on Oracle.","Cod
e":0,"Trace":[{"file":"/var/www/nextcloud/apps/dav/lib/CardDAV/CardDavBackend.php","line":1111,"function":"execute","class":"OC\\DB\\QueryBuilder\\QueryBuilder","type":"->","args":[]},{"file
":"/var/www/nextcloud/apps/dav/lib/CardDAV/CardDavBackend.php","line":1009,"function":"searchByAddressBookIds","class":"OCA\\DAV\\CardDAV\\CardDavBackend","type":"->","args":[["2"],"m",["FN"
,"ORG","EMAIL"],[]]},{"file":"/var/www/nextcloud/apps/dav/lib/CardDAV/AddressBookImpl.php","line":118,"function":"search","class":"OCA\\DAV\\CardDAV\\CardDavBackend","type":"->","args":["2",
"m",["FN","ORG","EMAIL"],[]]},{"file":"/var/www/nextcloud/lib/private/ContactsManager.php","line":52,"function":"search","class":"OCA\\DAV\\CardDAV\\AddressBookImpl","type":"->","args":["m",
["FN","ORG","EMAIL"],[]]},{"file":"/var/www/nextcloud/apps/circles/lib/Search/Contacts.php","line":45,"function":"search","class":"OC\\ContactsManager","type":"->","args":["m",["FN","ORG","E
MAIL"]]},{"file":"/var/www/nextcloud/apps/circles/lib/Service/SearchService.php","line":95,"function":"search","class":"OCA\\Circles\\Search\\Contacts","type":"->","args":["m"]},{"file":"/va
r/www/nextcloud/apps/circles/lib/Controller/MembersController.php","line":246,"function":"searchGlobal","class":"OCA\\Circles\\Service\\SearchService","type":"->","args":["m"]},{"file":"/var
/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php","line":169,"function":"searchGlobal","class":"OCA\\Circles\\Controller\\MembersController","type":"->","args":["m",4]},{"file":"/
var/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php","line":100,"function":"executeController","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[{"__class__":"OCA\\
Circles\\Controller\\MembersController"},"searchGlobal"]},{"file":"/var/www/nextcloud/lib/private/AppFramework/App.php","line":152,"function":"dispatch","class":"OC\\AppFramework\\Http\\Disp
atcher","type":"->","args":[{"__class__":"OCA\\Circles\\Controller\\MembersController"},"searchGlobal"]},{"file":"/var/www/nextcloud/lib/private/Route/Router.php","line":309,"function":"main
","class":"OC\\AppFramework\\App","type":"::","args":["OCA\\Circles\\Controller\\MembersController","searchGlobal",{"__class__":"OC\\AppFramework\\DependencyInjection\\DIContainer"},{"_route
":"circles.Members.searchGlobal"}]},{"file":"/var/www/nextcloud/lib/base.php","line":1008,"function":"match","class":"OC\\Route\\Router","type":"->","args":["/apps/circles/v1/globalsearch"]}
,{"file":"/var/www/nextcloud/index.php","line":37,"function":"handleRequest","class":"OC","type":"::","args":[]}],"File":"/var/www/nextcloud/lib/private/DB/QueryBuilder/QueryBuilder.php","Li
ne":229,"CustomMessage":"More than 1000 expressions in a list are not allowed on Oracle."},"userAgent":"Mozilla/5.0 -------------------------","version":"20.0.14.4"}

Signed-off-by: Carl Schwan carl@carlschwan.eu

@CarlSchwan CarlSchwan added the 3. to review Waiting for reviews label Feb 19, 2022
@CarlSchwan CarlSchwan added this to the Nextcloud 24 milestone Feb 19, 2022
@CarlSchwan CarlSchwan self-assigned this Feb 19, 2022
apps/dav/lib/CardDAV/CardDavBackend.php Outdated Show resolved Hide resolved
apps/dav/lib/CardDAV/CardDavBackend.php Outdated Show resolved Hide resolved
apps/dav/lib/CardDAV/CardDavBackend.php Outdated Show resolved Hide resolved
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@ChristophWurst
Copy link
Member

/backport to stable23

@ChristophWurst
Copy link
Member

/backport to stable21

@ChristophWurst
Copy link
Member

/backport to stable22

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan CarlSchwan force-pushed the fix/carddav-backend-1000-orache1 branch from 06d2e00 to cb7485e Compare February 21, 2022 13:30
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants