move root mount setup to mountproviders #31266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
CarlSchwan
reviewed
Feb 18, 2022
PVince81
reviewed
Feb 21, 2022
PVince81
reviewed
Feb 21, 2022
icewind1991
force-pushed
the
root-setup-mountprovider
branch
4 times, most recently
from
c0732ab
to
17e2bdd
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
root-setup-mountprovider
branch
from
17e2bdd
to
8b7c844
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
root-setup-mountprovider
branch
from
4738a20
to
b0ce876
Compare
…torage Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
…g part files Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
root-setup-mountprovider
branch
from
a4387f7
to
ec15020
Compare
|
Added ci setup with objectstore (multibucket) as root storage and fixed some failures when running with objectstore |
skjnldsv
requested review from
a team and
nickvergessen
and removed request for
a team
1 task
CarlSchwan
approved these changes
Mar 4, 2022
PVince81
reviewed
Mar 4, 2022
| @@ -0,0 +1,70 @@ | |||
| name: S3 primary storage | |||
There was a problem hiding this comment.
is this backportable separately?
PVince81
approved these changes
Mar 4, 2022
| // the entire operation will be safe | ||
|
|
||
| try { | ||
| $this->acquireLock(ILockingProvider::LOCK_EXCLUSIVE); |
There was a problem hiding this comment.
is this directly related to this PR or is this a fix that we could use separately ?
| @@ -0,0 +1,70 @@ | |||
| name: S3 primary storage | |||
There was a problem hiding this comment.
is this backportable separately?
|
I'll look into backporting the primary storage ci+fixes |
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes special casing for the root storage from the filesystem setup logic
Requires:
Part of #31265