Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to disable password policy enforcement for selected groups #31194

Merged
merged 1 commit into from
Apr 6, 2022
Merged

Allow to disable password policy enforcement for selected groups #31194

merged 1 commit into from
Apr 6, 2022

Conversation

CarlSchwan
Copy link
Member

@CarlSchwan CarlSchwan commented Feb 15, 2022 •
edited
Loading

Todos:

  • Adapt tests and add new one

Signed-off-by: Carl Schwan carl@carlschwan.eu

@CarlSchwan CarlSchwan added the 3. to review Waiting for reviews label Feb 15, 2022
@CarlSchwan CarlSchwan added this to the Nextcloud 24 milestone Feb 15, 2022
@CarlSchwan CarlSchwan self-assigned this Feb 15, 2022
@CarlSchwan CarlSchwan mentioned this pull request Feb 15, 2022
Closed
3 tasks
@PVince81
Copy link
Member

we also need to check the impact it might have on capabilities which might evaluate this and expose it to the clients

@CarlSchwan CarlSchwan force-pushed the feat/allow-to-exclude-groups-from-password-enforcement branch from ce1bed4 to f4875d7 Compare February 17, 2022 11:28
PVince81
PVince81 approved these changes Feb 17, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks fine, please verify with a client

@CarlSchwan CarlSchwan force-pushed the feat/allow-to-exclude-groups-from-password-enforcement branch from f4875d7 to e2d533c Compare February 18, 2022 13:53
@PVince81
Copy link
Member

Fixes #30161

@PVince81
Copy link
Member

conflicts with #31116

@PVince81
Copy link
Member

PVince81 commented Feb 21, 2022 •
edited
Loading

  • add config switch to config.sample.php allow_disabled_password_enforcement_groups

@PVince81 PVince81 mentioned this pull request Feb 21, 2022
Closed
1 task
@PVince81
Copy link
Member

@PVince81
Copy link
Member

I've renamed the config switch and prefixed with "sharing." like other similar configs in config.php

also added to config.sample.php

conflict still unresolved

@CarlSchwan CarlSchwan force-pushed the feat/allow-to-exclude-groups-from-password-enforcement branch from b029f70 to c903fb4 Compare March 4, 2022 11:09
PVince81
PVince81 approved these changes Mar 4, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81
Copy link
Member

PVince81 commented Mar 4, 2022

alright, so the tests still need adjusting: OCA\Settings\Tests\Settings\Admin\SharingTest

@CarlSchwan CarlSchwan force-pushed the feat/allow-to-exclude-groups-from-password-enforcement branch from c903fb4 to 78082e0 Compare March 4, 2022 15:05
@CarlSchwan CarlSchwan requested a review from Pytal March 9, 2022 10:56
@CarlSchwan CarlSchwan requested review from artonge and Pytal March 16, 2022 13:56
artonge
artonge approved these changes Mar 16, 2022
View reviewed changes
lib/private/Share20/Manager.php Show resolved Hide resolved
@skjnldsv skjnldsv mentioned this pull request Mar 24, 2022
Merged
@CarlSchwan CarlSchwan force-pushed the feat/allow-to-exclude-groups-from-password-enforcement branch from 708c9b3 to 654587e Compare March 28, 2022 09:13
@CarlSchwan CarlSchwan force-pushed the feat/allow-to-exclude-groups-from-password-enforcement branch from 654587e to 0fb60d7 Compare March 28, 2022 09:21
@CarlSchwan
Copy link
Member Author

/compile amend /

@nextcloud-command nextcloud-command force-pushed the feat/allow-to-exclude-groups-from-password-enforcement branch from 0fb60d7 to 9430927 Compare March 28, 2022 09:45
@szaimen
Copy link
Contributor

szaimen commented Mar 28, 2022

/rebase

@nextcloud-command nextcloud-command force-pushed the feat/allow-to-exclude-groups-from-password-enforcement branch from 9430927 to ab74fe3 Compare March 28, 2022 10:06
@szaimen
Copy link
Contributor

szaimen commented Mar 28, 2022

tests are failing

@szaimen szaimen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Mar 28, 2022
@blizzz blizzz mentioned this pull request Mar 31, 2022
Merged
@CarlSchwan CarlSchwan force-pushed the feat/allow-to-exclude-groups-from-password-enforcement branch from ab74fe3 to c35938e Compare April 5, 2022 15:20
@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Apr 5, 2022
@Pytal
Copy link
Member

Pytal commented Apr 5, 2022

/compile amend /

@CarlSchwan @PVince81 @nextcloud-command
Allow to disable password policy enforcement for selected groups
a29251e 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Co-authored-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the feat/allow-to-exclude-groups-from-password-enforcement branch from c35938e to a29251e Compare April 5, 2022 17:04
@PVince81 PVince81 merged commit b8b4d24 into master Apr 6, 2022
@PVince81 PVince81 deleted the feat/allow-to-exclude-groups-from-password-enforcement branch April 6, 2022 08:13
@PVince81
Copy link
Member

PVince81 commented Apr 6, 2022

tests unrelated

@PVince81
Copy link
Member

PVince81 commented Apr 6, 2022

@CarlSchwan please update the backports #31194 (comment)

@blizzz blizzz mentioned this pull request Apr 7, 2022
Merged
come-nc
come-nc reviewed Sep 1, 2022
View reviewed changes
apps/settings/templates/settings/admin/sharing.php
Comment on lines +133 to +134
<input type="checkbox" name="shareapi_default_expire_date" id="shareapiDefaultExpireDate" class="checkbox" value="1" <?php if ($_['shareDefaultExpireDateSet'] === 'yes') { print_unescaped('checked="checked"'); } ?> />

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate checkbox breaks the UI

@come-nc come-nc mentioned this pull request Sep 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc left review comments

@Pytal Pytal Pytal approved these changes

@artonge artonge artonge approved these changes

@PVince81 PVince81 PVince81 approved these changes

Assignees

@CarlSchwan CarlSchwan

Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
Nextcloud 24
Development

Successfully merging this pull request may close these issues.
6 participants
@CarlSchwan @PVince81 @szaimen @Pytal @artonge @come-nc