Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable23] Disable bulk upload by not advertising it #31171

Merged
merged 2 commits into from
Feb 15, 2022

Conversation

PVince81
Copy link
Member

It has been reported broken on many instances.
Disable it for now until it can be fixed.

@matthieugallien FYI

to be put into the 23.0.3 hotfix release, to avoid more surprises for now

It has been reported broken on many instances.
Disable it for now until it can be fixed.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@PVince81 PVince81 added bug 3. to review Waiting for reviews labels Feb 14, 2022
@PVince81 PVince81 added this to the Nextcloud 23.0.3 milestone Feb 14, 2022
@PVince81 PVince81 self-assigned this Feb 14, 2022
@PVince81
Copy link
Member Author

as stated in nextcloud/desktop#4243 I had this issue also on my own server and commenting out the capability (and restarting the client) solved the issue for me

@artonge
Copy link
Contributor

artonge commented Feb 14, 2022

Doesn't it make more sense to put the feature behind a feature flag in the desktop?

If we disable it, we can't even test it in real use cases.

@blizzz blizzz changed the title Disable bulk upload by not advertising it [stable23] Disable bulk upload by not advertising it Feb 14, 2022
@blizzz
Copy link
Member

blizzz commented Feb 14, 2022

Doesn't it make more sense to put the feature behind a feature flag in the desktop?

If we disable it, we can't even test it in real use cases.

Then all desktop clients would need an upgrade first. I think that would take longer. Short before the release, the best is to disable it for now and then go for a good solution that may involve the clients, too, and give some time to upgrade without this experience.

@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 14, 2022
@PVince81
Copy link
Member Author

restarted the build, too many weird fails due to env issues

@sagitariozod
Copy link

I confirm that disabling bulk upload on the server and restarting the clients fixes the problem.

Thank you very much for this solution.

Signed-off-by: Joas Schilling <coding@schilljs.com>
@PVince81
Copy link
Member Author

also to master / 24: #31736

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants