Update system tags icon #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 5, 2016 06:16
Change system tags icon from a magnifying glass to a newly created tag icon. Updates both the png and it's original source SVG.
Closed
|
I like it 👍 |
|
Could I ask you to optimize the SVG? There is a tool that shrinks the SVG significantly. @jancborchardt knows the name. |
Replace the system tags tag icon svg with a version that has been optimized by the optimization script (running scour)
|
Ok, I found the optimization script, installed scour and ran the script over the svg which worked fine. I've uploaded the optimized SVG into my branch and committed. Not sure if I need to create a new pull request or not. It seems to have included my optimized svg commit in my current pull request. |
|
👍 |
|
No, when you push to your local branch, the PR is also updated, until it is merged, as you can see above. |
nickvergessen
added
3. to review
|
OK. Thanks @jan! I'll try running Trimage+svgo over these when I have a minute. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces system tags magnifying glass icon with a newly created tag icon, as per discussion with Jan in issue #232