Add OPcache recommendations to Transifex #30950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaIng
added
3. to review
MichaIng
commented
Jan 31, 2022
|
/backport to stable23 |
MichaIng
force-pushed
the
enh/opcache-recommends-translation
branch
from
d4ca873
to
85dbfbc
Compare
CarlSchwan
approved these changes
Feb 1, 2022
|
MichaIng
force-pushed
the
enh/opcache-recommends-translation
branch
from
85dbfbc
to
bc91a05
Compare
MichaIng
force-pushed
the
enh/opcache-recommends-translation
branch
from
bc91a05
to
58e875a
Compare
tcitworld
approved these changes
Mar 17, 2022
|
/rebase |
nextcloud-command
force-pushed
the
enh/opcache-recommends-translation
branch
from
58e875a
to
13a27de
Compare
MichaIng
force-pushed
the
enh/opcache-recommends-translation
branch
from
13a27de
to
ce810ed
Compare
|
/rebase |
Fixes: #30941 Signed-off-by: MichaIng <micha@dietpi.com>
nextcloud-command
force-pushed
the
enh/opcache-recommends-translation
branch
from
ce810ed
to
31606c9
Compare
nickvergessen
approved these changes
Mar 22, 2022
Merged
blizzz
approved these changes
Mar 24, 2022
artonge
approved these changes
Mar 24, 2022
Pytal
approved these changes
Mar 24, 2022
come-nc
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #30941
I went the most simple way for now, leaving HTML code and PHP settings in the string. Of course it could be moved into the parameters array as well, I'm open for suggestions on this.
The fallback word "currently" is currently not translated. We could make the equivalent word "now", part of circles app and NC client's Transifex, available to core and use it instead? Is there a way to declare a string globally instead of having to translate it per-app?