Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert properties value to string before passing them to database #30771

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Convert properties value to string before passing them to database #30771

merged 1 commit into from
Jan 20, 2022

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Jan 20, 2022

This avoids an error when passing a complex property to PROPPATCH under PHP >= 7.4.

See litmus failures in #29286

Signed-off-by: Côme Chilliet come.chilliet@nextcloud.com

@come-nc
Convert properties value to string before passing them to database
40cdc54 
This avoids an error when passing a complex property to PROPPATCH under
 PHP >= 7.4.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc self-assigned this Jan 20, 2022
@come-nc come-nc requested a review from PVince81 January 20, 2022 14:10
@skjnldsv skjnldsv added this to the Nextcloud 24 milestone Jan 20, 2022
@nickvergessen
Copy link
Member

This cries for setting up the litmus tests with all supported php versions in parallel 🙈

@come-nc come-nc added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 20, 2022
PVince81
PVince81 approved these changes Jan 20, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@come-nc come-nc merged commit 9b5245f into master Jan 20, 2022
@come-nc come-nc deleted the fix/proppatch-convert-complex-properties branch January 20, 2022 17:31
@tcitworld tcitworld mentioned this pull request Feb 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

Assignees

@come-nc come-nc

Labels
3. to review Waiting for reviews bug feature: dav
Projects
None yet
Milestone
Nextcloud 24
Development

Successfully merging this pull request may close these issues.
4 participants
@come-nc @nickvergessen @PVince81 @skjnldsv