Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete files before cleaning cache when cleaning user files #30510

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

icewind1991
Copy link
Member

otherwise, when using object store, we loose track of which files the user owns before we can delete them

Signed-off-by: Robin Appelman robin@icewind.nl

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Jan 6, 2022
@icewind1991 icewind1991 added this to the Nextcloud 24 milestone Jan 6, 2022
@icewind1991
Copy link
Member Author

/backport to stable23

@icewind1991
Copy link
Member Author

/backport to stable22

Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, nice catch 👍

@PVince81
Copy link
Member

PVince81 commented Jan 7, 2022

@icewind1991 we might still be missing a cleanup job that will remove orphaned object store entries that have no matching filecache entries ? (separate issue)

@skjnldsv skjnldsv mentioned this pull request Mar 24, 2022
@blizzz blizzz mentioned this pull request Mar 31, 2022
This was referenced Apr 7, 2022
@blizzz blizzz modified the milestones: Nextcloud 24, Nextcloud 25 Apr 21, 2022
@PVince81
Copy link
Member

/rebase

@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 13, 2022
otherwise, when using object store, we loose track of which files the user owns before we can delete them

Signed-off-by: Robin Appelman <robin@icewind.nl>
@nextcloud-command nextcloud-command force-pushed the user-cleanup-storage-before-cache branch from 83d73b5 to db3093a Compare June 13, 2022 08:51
@pierreozoux
Copy link
Member

Thanks for the PR it is nice!

@PVince81 we just created a little go job to do just that:
https://lab.libreho.st/libre.sh/kubernetes/tools/-/tree/main/nextcloud-clean-versionned-bucket

We thought first to do it in php, but well, we don't have that much experience in php, and with the goroutine and the 100k of objects we had to clean 🤷‍♂️

@blizzz
Copy link
Member

blizzz commented Jun 21, 2022

so, should reset the label to 2 - developing?

@PVince81
Copy link
Member

this PR is still valid as it should prevent future cases

@PVince81 PVince81 merged commit cb9f342 into master Jul 26, 2022
@PVince81 PVince81 deleted the user-cleanup-storage-before-cache branch July 26, 2022 21:08
@PVince81
Copy link
Member

/backport to stable24

@backportbot-nextcloud
Copy link

The backport to stable24 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable23 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable22 failed. Please do this backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants