-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure trusted_proxies is an array #29522
Merged
nickvergessen
merged 3 commits into
master
from
bugfix/26256/make-sure-trusted_proxies-is-an-array
Nov 10, 2021
Merged
Make sure trusted_proxies is an array #29522
nickvergessen
merged 3 commits into
master
from
bugfix/26256/make-sure-trusted_proxies-is-an-array
Nov 10, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
requested review from
skjnldsv and
come-nc
and removed request for
a team
November 2, 2021 14:38
nickvergessen
commented
Nov 2, 2021
nickvergessen
force-pushed
the
bugfix/26256/make-sure-trusted_proxies-is-an-array
branch
from
November 2, 2021 15:56
e730bf0
to
b334c5c
Compare
skjnldsv
approved these changes
Nov 2, 2021
icewind1991
approved these changes
Nov 2, 2021
/backport to stable22 |
/backport to stable21 |
nickvergessen
force-pushed
the
bugfix/26256/make-sure-trusted_proxies-is-an-array
branch
from
November 3, 2021 10:09
b334c5c
to
1c635a4
Compare
Rebasing fixes psalm? lets see |
nickvergessen
added
4. to release
Ready to be released and/or waiting for tests to finish
and removed
3. to review
Waiting for reviews
labels
Nov 3, 2021
Signed-off-by: Joas Schilling <coding@schilljs.com>
… mock using a method list that contains duplicates: Signed-off-by: Joas Schilling <coding@schilljs.com>
…ller\CheckSetupController::__construct() Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
bugfix/26256/make-sure-trusted_proxies-is-an-array
branch
from
November 9, 2021 14:13
1c635a4
to
e8f7a08
Compare
Rebasing fixes psalm? lets see |
nickvergessen
deleted the
bugfix/26256/make-sure-trusted_proxies-is-an-array
branch
November 10, 2021 13:12
The backport to stable22 failed. Please do this backport manually. |
The backport to stable21 failed. Please do this backport manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #26256