-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toggle profile globally #29372
Toggle profile globally #29372
Conversation
Am I right, that this toggles globally, if profile pages are enabled or disabled and if they are disabled they can not be enabled by the individual user? If this is the case, there is need for another issue: I'd like to have public profiles "opt-in" as the default setting. |
@jolly-jump in the current state of this PR, setting the option to disabled would disable profile completely and users would not be able to enable their own profile individually. You've made a good suggestion so we will also add an admin option to set profile to enabled/disabled by default for all users and allow individual users to opt-in or opt-out. |
99f8fe7
to
13d2cb1
Compare
For those searching for a quick fix to disable all users profiles for now: update oc_accounts set data = JSON_SET(data, '$.profile_enabled', JSON_QUERY('{"value": "0", "scope": "v2-local", "verified": "0"}', '$')); |
2bfe1c9
to
a0d0460
Compare
Any idea when the feature will be ready to use? We use NC at our school und students must not be able to enable a public profile. I applied the workaround from @shieldwed , but this only applies to existing users. |
73cf679
to
1383b60
Compare
return filter_var( | ||
$account->getProperty(IAccountManager::PROPERTY_PROFILE_ENABLED)->getValue(), | ||
$config->getAppValue('settings', 'profile_enabled_by_default', '1'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we should document this somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And maybe it should be disabled by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we should document this somewhere?
Created a separate issue nextcloud/documentation#8122
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for the record from what we talked about in the chat:
- We are keeping Profile enabled by default
- Admins can easily disable it with this setting by default, with users still being able to override it
- New profile fields which are sensitive were a) introduced recently together with the visibility settings and b) not public by default, so if people don't want them to be visible, they didnt set them
83dc6c4
to
08ce416
Compare
@Pytal can you please rebase? Then lets merge this, I'd say |
08ce416
to
99bc520
Compare
sry Chris but tests are still failing :/ |
99bc520
to
62066d2
Compare
Looks unrelated but will rerun for safety |
62066d2
to
7fe627e
Compare
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
7fe627e
to
108abd7
Compare
🟢 |
/backport to stable23 |
|
Adds two new settings:
config.php
option'profile.enabled'
which defaults to true to enable/disable profile globallyClose #30866
Contributes to #28139