Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump doctrine/dbal from 3.0.0 to 3.1.3 #29344

Merged
merged 1 commit into from
Oct 22, 2021

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Oct 20, 2021

Let's see what CI thinks of this, but we're possibly in a safer position if we ship 23 with the latest fixes and compatibility in the database world.

@ChristophWurst ChristophWurst added this to the Nextcloud 23 milestone Oct 20, 2021
@ChristophWurst ChristophWurst requested review from skjnldsv and a team October 20, 2021 16:26
@ChristophWurst ChristophWurst self-assigned this Oct 20, 2021
@ChristophWurst ChristophWurst requested review from PVince81 and icewind1991 and removed request for a team October 20, 2021 16:26
@CarlSchwan
Copy link
Member

The ci is not happy. First, one is very probably related to this change

--

There was 1 failure:

  1. Test\DB\QueryBuilder\QueryBuilderTest::testFirstResult with data set #0 (null, array(99, 98, 97, 96, 95, 94, 93, 92, 91))
    Failed asserting that 0 is identical to null.

/home/runner/work/server/server/tests/lib/DB/QueryBuilder/QueryBuilderTest.php:132

--

There was 1 risky test:

  1. Test\Files\Node\FolderTest::testGet
    This test did not perform any assertions

/home/runner/work/server/server/tests/lib/Files/Node/FolderTest.php:89

--

@ChristophWurst ChristophWurst force-pushed the dependabot/composer/doctrine/dbal-3.1.3 branch 2 times, most recently from d0b9f1a to 364b8d8 Compare October 21, 2021 16:18
@ChristophWurst
Copy link
Member Author

1. Test\DB\QueryBuilder\QueryBuilderTest::testFirstResult with data set #0 (null, array(99, 98, 97, 96, 95, 94, 93, 92, 91))
   Failed asserting that 0 is identical to null.

Fixed. Doctrine changed its behavior and now always truly returns 0 instead of null.

@ChristophWurst ChristophWurst force-pushed the dependabot/composer/doctrine/dbal-3.1.3 branch from 364b8d8 to e76a671 Compare October 21, 2021 16:19
@ChristophWurst ChristophWurst added the pending documentation This pull request needs an associated documentation update label Oct 21, 2021
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@skjnldsv skjnldsv merged commit 7e3b6e7 into master Oct 22, 2021
@skjnldsv skjnldsv deleted the dependabot/composer/doctrine/dbal-3.1.3 branch October 22, 2021 09:35
@ChristophWurst ChristophWurst mentioned this pull request Oct 25, 2021
@skjnldsv skjnldsv mentioned this pull request Oct 25, 2021
25 tasks
@ChristophWurst ChristophWurst removed the pending documentation This pull request needs an associated documentation update label Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants