Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Symfony family and friends to v4.4.30 #29343

Merged
merged 1 commit into from
Oct 21, 2021
Merged

Bump Symfony family and friends to v4.4.30 #29343

merged 1 commit into from
Oct 21, 2021

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Oct 20, 2021 •
edited
Loading

@ChristophWurst ChristophWurst added this to the Nextcloud 23 milestone Oct 20, 2021
@ChristophWurst ChristophWurst self-assigned this Oct 20, 2021
@ChristophWurst ChristophWurst force-pushed the dependachristoph/composer/symfony-4.4.30-and-friends branch from 0c77959 to 55f279d Compare October 20, 2021 16:08
Pytal
Pytal approved these changes Oct 21, 2021
View reviewed changes
Copy link
Member

@Pytal Pytal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ CI unhappy

@skjnldsv
Copy link
Member

Static code analysis needs fix; drne failure unrelated

@ChristophWurst
Bump Symfony family and friends to v4.4.30
88490ea 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst force-pushed the dependachristoph/composer/symfony-4.4.30-and-friends branch from 55f279d to 88490ea Compare October 21, 2021 08:01
@ChristophWurst
Copy link
Member Author

Only Test\Share20\DefaultShareProviderTest::testGetAllShares failed and I think this is unrelated. @skjnldsv what do you think?

@ChristophWurst
Copy link
Member Author

Only Test\Share20\DefaultShareProviderTest::testGetAllShares failed and I think this is unrelated. @skjnldsv what do you think?

Restarted 🍿

@ChristophWurst ChristophWurst merged commit 9a8bb5e into master Oct 21, 2021
@ChristophWurst ChristophWurst deleted the dependachristoph/composer/symfony-4.4.30-and-friends branch October 21, 2021 15:45
@skjnldsv skjnldsv mentioned this pull request Oct 25, 2021
Merged
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@Pytal Pytal Pytal approved these changes

@dschuermann dschuermann Awaiting requested review from dschuermann

@Abijeet Abijeet Awaiting requested review from Abijeet

@patrickbaber patrickbaber Awaiting requested review from patrickbaber

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

Assignees

@ChristophWurst ChristophWurst

Labels
3. to review Waiting for reviews bug dependencies
Projects
None yet
Milestone
Nextcloud 23
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristophWurst @skjnldsv @Pytal