Add calendar object creation API to OCP #29188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
46 tasks
ChristophWurst
added
2. developing
miaulalala
force-pushed
the
enhancement/public-write-api
branch
from
64a7b5b
to
b9f9e35
Compare
miaulalala
requested review from
a team,
nickvergessen,
ArtificialOwl,
CarlSchwan,
ChristophWurst and
kesselb
and removed request for
a team
ChristophWurst
added
3. to review
ChristophWurst
approved these changes
Oct 14, 2021
miaulalala
force-pushed
the
enhancement/public-write-api
branch
from
9d3fac2
to
c8984c9
Compare
kesselb
approved these changes
Oct 14, 2021
miaulalala
force-pushed
the
enhancement/public-write-api
branch
from
7003ec9
to
51621cd
Compare
|
|
ChristophWurst
changed the title
Signed-off-by: Anna Larch <anna@nextcloud.com> Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
force-pushed
the
enhancement/public-write-api
branch
from
51621cd
to
0401d6d
Compare
ChristophWurst
added
the
4. to release
16 tasks
kesselb
approved these changes
Oct 15, 2021
This was referenced Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a public create method to the OCP calendar API.
This change contributes the first part of #20154 but without the hassle of creating a completely new API, but rather extending what we already have. This means apps that provide calendars can now adapt to this and optionally allow other app devs to write to these calendars.
For simplicity the written calendar object is handed over as a string. Therefore we don't have to define a complex type that can contain the many properties a calendar object can have, nor do we leak the internal sabre types.
This change is required for nextcloud/calendar#3478 so that appointment events can be written to a user's calendar.