Scheduling plugin not updating responding attendee status #28997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable22 |
|
/backport to stable21 |
|
/backport to stable20 |
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Anna Larch <anna@nextcloud.com>
kesselb
force-pushed
the
fix/set-attendee-as-recipient
branch
from
21c0460
to
817e7a9
Compare
For local users it's possible to select their calendar via the principal url and first update their own attendance status. External users have no calendar event hence the recipient is the organizer. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
force-pushed
the
fix/set-attendee-as-recipient
branch
from
817e7a9
to
fab887c
Compare
st3iny
approved these changes
Oct 19, 2021
skjnldsv
approved these changes
Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take 2 on fixing the attendee's own status not updating.
Thanks to @kesselb we now know the correct way to create an iTip message.
From his comment on the other PR: #28094
The purpose of this pull request is to fix an issue with updating the attendance status for the attendee itself. To reproduce create a event and invite Alice and Bob. Wait for Bob's invitation email and accept the invite. The attendance status for the organizer and Alice is updated (Bob accepted the invite). In Bob's calendar event the attendance status is still pending.
A possible explanation for this case is the way we handle event invitations. If a user accept or decline an invitation a iTip message is generated.
server/apps/dav/lib/Controller/InvitationResponseController.php
Lines 200 to 201 in 215aef3
The recipient is used to select the right event from the calendar. When Alice accept the invite an iTip message is generated with sender = alice@example.org and recipient = organizer@example.org. The event for recipient organizer@example.org is selected and the attendance status for alice@example.org updated. Then for every other attendee another iTip message is generated to also update their event.
https://github.com/nextcloud/3rdparty/blob/6876f1fce8d1c70790c165dd7ed0b4214364e397/sabre/dav/lib/CalDAV/Schedule/Plugin.php#L527-L538
Sabre assume that we already updated Alice event and there is no need to sent a iTip message to Alice.
When sender = recipient the calendar event for the attendee is updated and a iTip message for the organizer and other attendees generated and properly updated.
Fixes nextcloud/calendar#2861