Fix public shared folder page when quota includes external storages #28911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaimen
reviewed
Sep 22, 2021
Comment on lines
+410
to
+411
| OC_Util::tearDownFS(); | ||
| OC_Util::setupFS($share->getShareOwner()); |
There was a problem hiding this comment.
I guess this might have some performance implications. So probably @icewind1991 should have a look when he is back from vacation.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
When the quota storage wrapper is used (that is, when the share owner
has a quota set) and "quota_include_external_storage" is enabled when
checking the free space "Filesystem::getFileInfo('', 'ext')" is called,
which requires the file system to have been initialized. This is
explicitly done now in "showShare" similar to what is done in
"downloadShare".
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
force-pushed
the
fix-public-shared-folder-page-when-quota-includes-external-storages
branch
from
686abcc
to
a43d664
Compare
|
/backport to stable22 |
|
/backport to stable21 |
danxuliu
added
3. to review
Merged
|
What's the status here? |
|
It needs feedback from @icewind1991 ... |
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced May 3, 2023
Merged
Closed
Merged
Merged
Merged
|
As there is no feedback since a while I will close this ticket. |
skjnldsv
added
2. developing
skjnldsv
deleted the
fix-public-shared-folder-page-when-quota-includes-external-storages
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27322
When the quota storage wrapper is used (that is, when the share owner has a quota set) and
quota_include_external_storageis enabled when checking the free spaceFilesystem::getFileInfo('', 'ext')is called, which requires the file system to have been initialized. This is explicitly done now inshowSharesimilar to what is done indownloadShare.Pending:
For now this just includes an integration test that shows it.How to reproduce
quota_include_external_storage, for example, withocc config:system:set quota_include_external_storage --value=true --type booleanResult with this pull request
The public shared folder page is opened
Result without this pull request
The server returns an internal error