Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "never catch" catches in OC_App #28138

Merged
merged 1 commit into from
Oct 23, 2021
Merged

Fix "never catch" catches in OC_App #28138

merged 1 commit into from
Oct 23, 2021

Conversation

zorn-v
Copy link
Member

@zorn-v zorn-v commented Jul 23, 2021

Need to check another legacy. Need to explicitly add to use or do not forget add slash \

@szaimen
Copy link
Contributor

szaimen commented Aug 31, 2021

Is this ready for review?

@szaimen szaimen added the 2. developing Work in progress label Aug 31, 2021
@szaimen szaimen added this to the Nextcloud 23 milestone Aug 31, 2021
@skjnldsv skjnldsv mentioned this pull request Oct 13, 2021
@skjnldsv skjnldsv requested review from a team, nickvergessen, PVince81 and skjnldsv and removed request for a team October 21, 2021 15:39
@skjnldsv skjnldsv added 3. to review Waiting for reviews bug and removed 2. developing Work in progress labels Oct 21, 2021
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@skjnldsv
Copy link
Member

/rebase

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 22, 2021
Need to check another legacy. Need to explicitly add to use or do not forget add slash `\`
@skjnldsv skjnldsv merged commit c5e9f37 into master Oct 23, 2021
@skjnldsv skjnldsv deleted the zorn-v-patch-2 branch October 23, 2021 09:18
@nickvergessen
Copy link
Member

For me this now yields a warning on all maschines?

PHP Warning:  The use statement with non-compound name 'Throwable' has no effect in /var/www/html/lib/private/legacy/OC_App.php on line 66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants