Implementation of Target_Blank option to open External links in a new tab (link with External module Issue #74) #27725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Linked to nextcloud/external#268 |
Signed-off-by: christophe canovas <christophecanovas66@gmail.com>
ChrisCano66
force-pushed
the
Add_Target_Blank_To_Links_Menu
branch
from
edb2140
to
7b1b21a
Compare
|
| @@ -55,6 +55,7 @@ | |||
| <?php foreach ($_['navigation'] as $entry): ?> | |||
| <li data-id="<?php p($entry['id']); ?>" class="hidden" tabindex="-1"> | |||
| <a href="<?php print_unescaped($entry['href']); ?>" | |||
| <?php if ($entry['target']): ?> target="_blank"<?php endif; ?> | |||
There was a problem hiding this comment.
Should we also set rel="noreferrer noopener" ?
|
@ChrisCano66 please address the review. Thanks! |
szaimen
added
2. developing
|
Hello,
Chris was on vacation, he will work on the project again very soon. Sincerely, Axel for the FCCL. |
Merged
|
Rebased and fixed in #31180 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix nextcloud/external#79
** External module Issue : #74 "Open in new tab" **
** External module pull request : "Implementation of Target_Blank option to open External links in a new tab #268" **
Hi !
We are a team that contributes to the improvement and production of free software for the general public. Moreover, being a NextCloud user, we wanted to improve it and especially the External module.
Thus, we wanted to respond to Issue #74 which requires the opening of external links to a new tab.
We have therefore improved the source code of the External module by modifying the following:
On External front-end, we added the possibility to check the "New Tab" option.
We have modified the files "admin.js", "site.handlebars" and "style.css" in the External module where we added a "target" option.
But we needed to modify some Nextcloud files too : "layout.user.php" and "MainMenu.js". So we also made a contribution on NextCloud Server in order for the implementation to be done properly.
For setting up the data option in the database and link the front-end to back-end, we had to modify the following files in External module :
"Application.php", "APIController.php", "SitesManager.php", "Personnal.php", "BeforeTemplateRenderedListener.php" and " Capabilites.php".
In all of this files, we added the "target" option which allows us to follow the activation of the front-end option to the back-end and the database.
If you have any questions about the implementation of the option, please do not hesitate to contact us by email at the following address: contact@fcclvandoeuvre.fr or christophecanovas66@gmail.com.
Regards.