Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide personal circle from the sharedWithMe #27633

Closed
wants to merge 1 commit into from

Conversation

ArtificialOwl
Copy link
Member

Personal Circle are hidden to its own members (but the owner of the Circle).
Because shareWithDisplayName cannot be empty, or it will be replaced by the Id of the share, the work around is that the Circles App will returns a name with a space char.

The idea is that when sharing a file to a personal Circle, the recipient of the share is not aware of the fact that he is in a personal Circle.

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
@szaimen szaimen added the 3. to review Waiting for reviews label Jun 23, 2021
@szaimen szaimen added this to the Nextcloud 22 milestone Jun 23, 2021
undefined,
{ escape: false }
)
if (share.shareWithDisplayName === ' ') {
Copy link
Member

@blizzz blizzz Jun 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a single whitespace?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, as said if I return an empty string, the ID of the Circle/Share will be used as displayName. single whitespace is a quick workaround

@blizzz blizzz mentioned this pull request Jun 23, 2021
39 tasks
@blizzz blizzz modified the milestones: Nextcloud 22, Nextcloud 23 Jun 24, 2021
@szaimen
Copy link
Contributor

szaimen commented Aug 31, 2021

What is missing here?

@skjnldsv skjnldsv mentioned this pull request Oct 13, 2021
@skjnldsv skjnldsv modified the milestones: Nextcloud 23, Nextcloud 24 Oct 22, 2021
@skjnldsv skjnldsv mentioned this pull request Mar 24, 2022
@blizzz blizzz mentioned this pull request Mar 31, 2022
This was referenced Apr 7, 2022
@blizzz blizzz modified the milestones: Nextcloud 24, Nextcloud 25 Apr 21, 2022
This was referenced Aug 12, 2022
This was referenced Aug 24, 2022
This was referenced Sep 6, 2022
@skjnldsv skjnldsv deleted the fix/noid/hide-personal-circles branch March 14, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants