Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix getTableNamesWithoutPrefix() #27119

Closed

Conversation

ArtificialOwl
Copy link
Member

Looking at the code, it seems that getTableNamesWithoutPrefix() is not working as expected.

The method getTableNames() from the dbal will returns 'database.prefix_table_name' instead of 'prefix_table_name' making the strpos() condition always invalid.

This fix will make getTableNames() extracting the database from the list returned by dbal, getTableNamesWithoutPrefix() will use this new list and remove the prefix.

The idea is that even getTableNames() should not contains the name of the database.

@ArtificialOwl ArtificialOwl added the 3. to review Waiting for reviews label May 26, 2021
@ArtificialOwl ArtificialOwl added this to the Nextcloud 22 milestone May 26, 2021
@blizzz blizzz mentioned this pull request Jun 2, 2021
57 tasks
@blizzz blizzz added the bug label Jun 2, 2021
@MorrisJobke MorrisJobke mentioned this pull request Jun 10, 2021
59 tasks
This was referenced Jun 16, 2021
@blizzz blizzz modified the milestones: Nextcloud 22, Nextcloud 23 Jun 24, 2021
@skjnldsv
Copy link
Member

What's the status here? :)

@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Aug 18, 2021
@nickvergessen
Copy link
Member

I think it needs a rebase and a second review

@skjnldsv skjnldsv mentioned this pull request Oct 13, 2021
@skjnldsv
Copy link
Member

/rebase

@skjnldsv
Copy link
Member

It is ready for reviews @ArtificialOwl ?

ArtificialOwl and others added 3 commits October 22, 2021 10:35
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nextcloud-command nextcloud-command force-pushed the bugfix/noid/get-table-names-without-prefix branch from 2eab957 to 5fe0407 Compare October 22, 2021 10:35
@skjnldsv skjnldsv mentioned this pull request Oct 25, 2021
25 tasks
@skjnldsv skjnldsv modified the milestones: Nextcloud 23, Nextcloud 24 Oct 25, 2021
@skjnldsv skjnldsv mentioned this pull request Mar 24, 2022
@blizzz blizzz mentioned this pull request Mar 31, 2022
This was referenced Apr 7, 2022
@blizzz blizzz removed this from the Nextcloud 24 milestone Apr 21, 2022
@blizzz blizzz added this to the Nextcloud 25 milestone Apr 21, 2022
This was referenced Aug 12, 2022
This was referenced Aug 24, 2022
This was referenced Sep 6, 2022
@nickvergessen nickvergessen deleted the bugfix/noid/get-table-names-without-prefix branch September 14, 2022 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants