Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Quick Review] executeUpdate is also deprecated #27104

Merged
merged 1 commit into from
May 25, 2021
Merged

[Quick Review] executeUpdate is also deprecated #27104

merged 1 commit into from
May 25, 2021

Conversation

LukasReschke
Copy link
Member

server/lib/private/DB/QueryBuilder/QueryBuilder.php

Lines 312 to 323 in 1089ad5

/**
* Monkey-patched compatibility layer for apps that were adapted for Nextcloud 22 before
* the first beta, where executeStatement was named executeUpdate.
*
* Static analysis should catch those misuses, but until then let's try to keep things
* running.
*
* @internal
* @deprecated
* @todo drop ASAP
*/
public function executeUpdate(): int {

@LukasReschke LukasReschke changed the title executeUpdate is also deprecated [Quick Review] executeUpdate is also deprecated May 25, 2021
@LukasReschke LukasReschke added the 3. to review Waiting for reviews label May 25, 2021
@LukasReschke LukasReschke added this to the Nextcloud 22 milestone May 25, 2021
@LukasReschke LukasReschke requested a review from kesselb May 25, 2021 18:31
@kesselb kesselb merged commit 1b21b17 into master May 25, 2021
@kesselb kesselb deleted the properly-name-execute branch May 25, 2021 18:44
@MorrisJobke MorrisJobke mentioned this pull request May 26, 2021
Merged
98 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kesselb kesselb kesselb approved these changes

@blizzz blizzz blizzz approved these changes

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 22
Development

Successfully merging this pull request may close these issues.
3 participants
@LukasReschke @blizzz @kesselb