Move files_external to IBootstrap and remove some deprecated stuff in the process #26319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
force-pushed
the
files_external_app.php
branch
3 times, most recently
from
45b6e76
to
c0436c3
Compare
blizzz
approved these changes
Mar 26, 2021
MorrisJobke
reviewed
Mar 29, 2021
| @@ -120,7 +120,7 @@ protected function configure() { | |||
| } | |||
|
|
|||
| protected function execute(InputInterface $input, OutputInterface $output): int { | |||
| $user = $input->getOption('user'); | |||
| $user = (string) $input->getOption('user'); | |||
There was a problem hiding this comment.
The return value could be string|string[]|bool|null. MInd to remove this change for now and then we look into make this correct?
There was a problem hiding this comment.
psalm wants the cast
There was a problem hiding this comment.
But casting an array to string will cause issues, no?
Signed-off-by: Robin Appelman <robin@icewind.nl>
blizzz
force-pushed
the
files_external_app.php
branch
from
c0436c3
to
94f0c10
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
|
rebased |
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
blizzz
added
4. to release
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
MorrisJobke
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.