-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dav respect disallow sharing with groups #25658
Dav respect disallow sharing with groups #25658
Conversation
not sure if enough as there's another PR here for ShareesAPIController with more changes: #25744 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 tested with Talk.
The groups are not visible in the search any more when creating a conversation.
build restarted |
Btw your todo should be solved already with the changes here as most of the apps are using the collaboration endpoint (GroupPlugin class) or the dav principal thing which you both modified |
Follow up Talk ticket: nextcloud/spreed#5360 I do have some small doubts: because creating a conversation is not strictly about sharing, just adding people. It just happens that Talk is using the sharing API there so is affected by this restriction. |
Not sure what you mean, it was just about hiding "group" from placeholders like @PVince81 did with Talk. |
Signed-off-by: Joas Schilling <coding@schilljs.com>
Closes #25390 Signed-off-by: Thomas Citharel <tcit@tcit.fr>
6f43211
to
1c0d975
Compare
Replaces #25391 (didn't see it straight away 🙈) and adds tests.
Fixes #25390
Fixes nextcloud/calendar#2744
Todo