Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate the internal IDBConnection event name constants #25543

Merged
merged 1 commit into from
Feb 9, 2021
Merged

Deprecate the internal IDBConnection event name constants #25543

merged 1 commit into from
Feb 9, 2021

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Feb 9, 2021 •
edited
Loading

I'm also ok with doing this even for 21.0.0 …

@ChristophWurst
Deprecate the internal IDBConnection event name constants
3d075c3 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst added this to the Nextcloud 22 milestone Feb 9, 2021
@ChristophWurst ChristophWurst self-assigned this Feb 9, 2021
@faily-bot
Copy link

faily-bot bot commented Feb 9, 2021

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 2061: failure

checkers

@ChristophWurst ChristophWurst added the pending documentation This pull request needs an associated documentation update label Feb 9, 2021
@ChristophWurst
Copy link
Member Author

CI is happy, checkers are fixed with #25542

rullzer
rullzer approved these changes Feb 9, 2021
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets do this and move #25471 forward then. Maybe by adding the remaining things as well.

@ChristophWurst ChristophWurst mentioned this pull request Feb 9, 2021
Closed
5 tasks
@nickvergessen
Copy link
Member

Did we add this for 20 or 21, then we could just remove it

@nickvergessen
Copy link
Member

Ah two were backported to 20 and the others were there before

@ChristophWurst ChristophWurst merged commit f96f0f6 into master Feb 9, 2021
@ChristophWurst ChristophWurst deleted the deprecate/idb-events branch February 9, 2021 17:50
@ChristophWurst ChristophWurst removed the pending documentation This pull request needs an associated documentation update label Jul 5, 2021
@ChristophWurst ChristophWurst mentioned this pull request Jul 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

@kesselb kesselb Awaiting requested review from kesselb

Assignees

@ChristophWurst ChristophWurst

Labels
3. to review Waiting for reviews technical debt
Projects
None yet
Milestone
Nextcloud 22
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristophWurst @nickvergessen @rullzer