Keep direct login active when redirecting #25424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <jus@bitgrid.net>
|
/backport to stable20 |
|
/backport to stable19 |
rullzer
approved these changes
Feb 1, 2021
ChristophWurst
approved these changes
Feb 1, 2021
juliushaertl
added
4. to release
|
Psalm failure is unrelated |
This was referenced Feb 2, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When SAML is configured with allowing multiple auth backends and the user uses the direct login method the user was just redirected to the auth picker again. This makes sure that we always end up in the direct login form where the error about the wrong credentials is displayed.