Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/app fetcher php compat comparison #25335

Merged
merged 2 commits into from
Jan 27, 2021
Merged

Fix/app fetcher php compat comparison #25335

merged 2 commits into from
Jan 27, 2021

Commits on Jan 26, 2021

  1. Revert "Fix comparison of PHP versions" 

    This reverts commit bedd9ac.
    @ChristophWurst
    ChristophWurst committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    652bf9d View commit details
    Browse the repository at this point in the history

  2. Fix app fetcher php comparison to allow wider ranges 

    When app app specifies php 7.4 as upper limit we have to allow the
installation on php>7.4.0. The previous version check didn't do that.
This adjusts the regexes to discard any irrelevant suffix after the
three version numbers so that we can use more fine granular checks than
php's version_compare can do out of the box, like for php 7.4 we only
compare the major and minor version numbers and ignore the patch level.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
    @ChristophWurst
    ChristophWurst committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    b4f71cc View commit details
    Browse the repository at this point in the history