Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReplyTo option for sharebymail Issue #24139 #24978

Merged
merged 4 commits into from
Feb 19, 2021
Merged

ReplyTo option for sharebymail Issue #24139 #24978

merged 4 commits into from
Feb 19, 2021

Conversation

dems54
Copy link
Contributor

@dems54 dems54 commented Jan 5, 2021 •
edited by skjnldsv
Loading

Should let users decide if anwsers to be sent to their account email, or to nextcloud server email

fix #24139

@dems54 dems54 changed the title Reply to option for sharebymail Issue #24139 ReplyTo option for sharebymail Issue #24139 Jan 5, 2021
@dems54 dems54 force-pushed the issue24139 branch 2 times, most recently from 3d2919b to 5dc9fa3 Compare January 8, 2021 00:23
@dems54
Copy link
Contributor Author

dems54 commented Jan 11, 2021

For review please : @skjnldsv @rullzer @ChristophWurst @juliushaertl

(I hope this is the right way to ask for reviewers, this is my first PR, many thanks 🙂)

@skjnldsv skjnldsv added this to the Nextcloud 22 milestone Jan 12, 2021
@skjnldsv
Copy link
Member

Hey! Thanks :)
Can you rebase and squash your commits into one?

juliusknorr
juliusknorr approved these changes Jan 12, 2021
View reviewed changes
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpicks, otherwise fine by me 👍

@dems54
Copy link
Contributor Author

dems54 commented Jan 12, 2021

Hey! Thanks :)
Can you rebase and squash your commits into one?

Rebase and squash are OK.
But I don't know why Static Code Analysis is now NOK ? It doesn't seem to relate to my commit...

@dems54
Copy link
Contributor Author

dems54 commented Jan 12, 2021

Small nitpicks, otherwise fine by me 👍

Good suggestions.
This is my first PR : who must validte your propositions ?

@skjnldsv
Copy link
Member

But I don't know why Static Code Analysis is now NOK ? It doesn't seem to relate to my commit...

No, it doesn't indeed. Just ignore

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 27, 2021
@dems54 dems54 requested a review from rullzer January 27, 2021 21:33
@dems54
Copy link
Contributor Author

dems54 commented Jan 27, 2021

Possible to merge this PR in NC20 or NC21 ?

dems54 and others added 3 commits January 28, 2021 15:57
@dems54
ReplyTo option for sharebymail Issue nextcloud#24139
4ac636d 
Signed-off-by: Nicolas SIMIDE <2083596+dems54@users.noreply.github.com>
@dems54 @juliusknorr
Update apps/sharebymail/lib/Settings/SettingsManager.php
0a8d934 
Small nitpicks

Co-authored-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Nicolas SIMIDE <2083596+dems54@users.noreply.github.com>
@dems54 @juliusknorr
Update apps/sharebymail/lib/Settings/SettingsManager.php
1427a9a 
Small nitpicks

Co-authored-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Nicolas SIMIDE <2083596+dems54@users.noreply.github.com>
@dems54
ReplyTo option for sharebymail - Issue nextcloud#24139 - Little bug fix
69bf0c8 
Signed-off-by: Nicolas SIMIDE <2083596+dems54@users.noreply.github.com>
@dems54
Copy link
Contributor Author

dems54 commented Feb 18, 2021

@rullzer it's ok for you ?

@skjnldsv skjnldsv merged commit 9464308 into nextcloud:master Feb 19, 2021
@welcome
Copy link

welcome bot commented Feb 19, 2021

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@skjnldsv
Copy link
Member

NC22

This was referenced Feb 25, 2021
Merged
Closed
This was referenced Mar 22, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@rullzer rullzer Awaiting requested review from rullzer

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement feature: emails feature: sharing
Projects
None yet
Milestone
Nextcloud 22
5 participants
@dems54 @skjnldsv @rullzer @juliusknorr @ChristophWurst