allow using any ldap property as login name when using login credentials #24955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge login credentials Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
external-storage-login-ldap
branch
from
5c8013e
to
58f3f5c
Compare
blizzz
reviewed
Jan 7, 2021
Comment on lines
+122
to
+137
| $access = $ldap->getLDAPAccess($user->getUID()); | ||
| $connection = $access->getConnection(); | ||
| $key = "external_login::" . $user->getUID() . "::" . $property; | ||
| $cached = $connection->getFromCache($key); | ||
|
|
||
| if ($cached !== null) { | ||
| return $cached; | ||
| } | ||
|
|
||
| $value = $access->readAttribute($access->username2dn($user->getUID()), $property); | ||
| if (count($value) > 0) { | ||
| $value = current($value); | ||
| } else { | ||
| return null; | ||
| } | ||
| $connection->writeToCache($key, $value); |
There was a problem hiding this comment.
I'd prefer it would use \OCP\ILDAPProvider (via its factory) instead of using private user_ldap classes. https://github.com/nextcloud/server/tree/master/lib/public/LDAP
|
Either way. It should not have been merged after feature freeze → Reverting |
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using ldap, there are setups where neither the uid nor the loginname are the "correct" username to pass to external storages.
This adds an option to use any ldap property as the username to pass to the external storage, you can configure it using