Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump doctrine/dbal from 2.12.0 to 3.0.0 #24948

Merged
merged 4 commits into from
Jan 8, 2021

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Jan 3, 2021

Required for php8 compat.

Changed APIs

Vanished APIs (e.g. because the new adapter can't provide them)

  • $qb->execute()->bindParam() (not used anyway)
  • $qb->execute()->bindValue() (not used anyway)
  • $qb->execute()->columnCount() (not used anyway)
  • $qb->execute()->errorCode() (not used anyway)
  • $qb->execute()->errorInfo() (not used anyway)
  • $qb->execute()->setFetchMode() (not used anyway)

Todo

Details of the breaking changes: https://github.com/doctrine/dbal/blob/3.0.x/UPGRADE.md#the-pingableconnection-interface-is-removed

@kesselb
Copy link
Contributor

kesselb commented Jan 3, 2021

https://github.com/doctrine/dbal/releases/tag/3.0.0

That are many changes 😨

@ChristophWurst
Copy link
Member Author

https://github.com/doctrine/dbal/releases/tag/3.0.0

That are many changes fearful

Yes. And it's landing at a very unfortunate time for us. They won't release the 2.x for php8, so we either upgrade to 3.x for 21 or we'll have loads of problems later on.

@rullzer rullzer mentioned this pull request Jan 4, 2021
5 tasks
lib/public/DB/IPreparedStatement.php Outdated Show resolved Hide resolved
lib/public/DB/IPreparedStatement.php Outdated Show resolved Hide resolved
@MorrisJobke

This comment has been minimized.

@ChristophWurst ChristophWurst force-pushed the dependabot/composer/doctrine/dbal-3.0.0 branch 2 times, most recently from 366e124 to 434bd66 Compare January 8, 2021 08:49
@ChristophWurst ChristophWurst marked this pull request as ready for review January 8, 2021 08:49
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 8, 2021
@ChristophWurst

This comment has been minimized.

@MorrisJobke

This comment has been minimized.

@MorrisJobke

This comment has been minimized.

@ChristophWurst

This comment has been minimized.

ChristophWurst and others added 3 commits January 8, 2021 11:45
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst force-pushed the dependabot/composer/doctrine/dbal-3.0.0 branch from 434bd66 to f0c6cfd Compare January 8, 2021 10:45
…un into docker pull rate limits

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Quick smoke test also looked good.

Copy link
Member Author

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 For Morris' parts

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works here 👍

@ChristophWurst ChristophWurst merged commit 81302f7 into master Jan 8, 2021
@ChristophWurst ChristophWurst deleted the dependabot/composer/doctrine/dbal-3.0.0 branch January 8, 2021 13:58
@ChristophWurst ChristophWurst removed the pending documentation This pull request needs an associated documentation update label Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants