Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable20] Avoid huge exception argument logging #24876

Merged
merged 1 commit into from
Dec 30, 2020
Merged

[stable20] Avoid huge exception argument logging #24876

merged 1 commit into from
Dec 30, 2020

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #24874

@rullzer @backportbot
Avoid huge exception argument logging
6762e61 
In some cases it might happen that you have an argument that deep down
somewhere has an array with a lot of entries (think thousands). Now
before we would just happily print them all. Which would fill the log.

Now it will just print the first 5. And add a line that there are N
more.

If you are on debug level we will still print them all.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 20.0.5 milestone Dec 29, 2020
@rullzer rullzer added the 3. to review Waiting for reviews label Dec 29, 2020
@juliusknorr juliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 29, 2020
@rullzer rullzer merged commit f16746e into stable20 Dec 30, 2020
@rullzer rullzer deleted the backport/24874/stable20 branch December 30, 2020 09:51
@rullzer rullzer mentioned this pull request Jan 5, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@rullzer rullzer rullzer approved these changes

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement
Projects
None yet
Milestone
Nextcloud 20.0.5
Development

Successfully merging this pull request may close these issues.
3 participants
@rullzer @ChristophWurst @juliusknorr