Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup bundle files before checking the rebuild #24865

Merged
merged 1 commit into from
Dec 29, 2020

Conversation

juliushaertl
Copy link
Member

After a6d343b we ended up with having lots of unused chunks in the settings app. We should in addition to the regular build clean up the previous chunks to make sure that those leftovers will be catched by CI as well.

@juliushaertl
Copy link
Member Author

Tests should fail and be happy again after #24772

@rullzer
Copy link
Member

rullzer commented Dec 29, 2020

Tests should fail and be happy again after #24772

Don't seem to fail

@juliushaertl
Copy link
Member Author

There we go https://github.com/nextcloud/server/pull/24865/checks?check_run_id=1620792109 I picked the wrong makefile target that runs the checkout after removing the files 🙈

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@faily-bot
Copy link

faily-bot bot commented Dec 29, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 797: failure

postgres9-php7.3

Show full log
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\User\DatabaseTest::testSearch
Failed asserting that actual size 3 matches expected size 2.

/drone/src/tests/lib/User/Backend.php:114
/drone/src/tests/lib/User/DatabaseTest.php:125

@juliushaertl juliushaertl added the 3. to review Waiting for reviews label Dec 29, 2020
@juliushaertl juliushaertl added this to the Nextcloud 21 milestone Dec 29, 2020
@juliushaertl
Copy link
Member Author

Rebased, relevant tests are happy

@rullzer rullzer merged commit 4c01f0d into master Dec 29, 2020
@rullzer rullzer deleted the tests/node-build-clean branch December 29, 2020 14:46
@rullzer rullzer mentioned this pull request Dec 30, 2020
39 tasks
@juliushaertl
Copy link
Member Author

/backport to stable20

@backportbot-nextcloud
Copy link

The backport to stable20 failed. Please do this backport manually.

@PVince81
Copy link
Member

PVince81 commented Feb 5, 2021

backport to stable20 is here: #25504

I checked stable21 and it already has the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants