Limit getIncomplete query to one row #24715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
|
It's not really a bug. I would still recommend to backport it. |
rullzer
approved these changes
Dec 21, 2020
|
/backport to stable20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this while debugging #24401.
How to test:
getIncomplete$result->rowCount()) that the query returns x rows but only the first row is consumedThis pull request limits the number of results to 1.
Limit to one was already set for < Nextcloud 18 and got lost in a bigger refactoring: d3b6dbc#diff-f36621cc749f37af880e8d2d5ea4b70870a0a13de93ce1461cc99be75e1abf47L833-L834 (the second argument for prepare is limit).