Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable20] use storage copy implementation when doing dav copy #24590

Merged
merged 1 commit into from
Jan 7, 2021
Merged

[stable20] use storage copy implementation when doing dav copy #24590

merged 1 commit into from
Jan 7, 2021

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #24358

@icewind1991 @backportbot
use storage copy implementation when doing dav copy
6790369 
instead of using the sabredav fallback (which does a read+write stream copy)

this greatly speeds up dav copies

Signed-off-by: Robin Appelman <robin@icewind.nl>
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 20.0.3 milestone Dec 7, 2020
@faily-bot
Copy link

faily-bot bot commented Dec 7, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 276: failure

mysql5.6-php7.2

Show full log 
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Files\Cache\Wrapper\CachePermissionsMaskTest::testSearchQueryByTag
Failed asserting that 2 matches expected 3.

/drone/src/tests/lib/Files/Cache/CacheTest.php:363

@rullzer rullzer mentioned this pull request Dec 7, 2020
Merged
@rullzer rullzer mentioned this pull request Dec 14, 2020
Merged
@rullzer rullzer added the 3. to review Waiting for reviews label Dec 15, 2020
@rullzer rullzer mentioned this pull request Jan 5, 2021
Merged
1 task
MorrisJobke
MorrisJobke approved these changes Jan 7, 2021
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@MorrisJobke MorrisJobke merged commit 8295cc9 into stable20 Jan 7, 2021
@MorrisJobke MorrisJobke deleted the backport/24358/stable20 branch January 7, 2021 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@icewind1991 icewind1991 Awaiting requested review from icewind1991

Assignees
No one assigned
Labels
3. to review Waiting for reviews performance 🚀
Projects
None yet
Milestone
Nextcloud 20.0.5
Development

Successfully merging this pull request may close these issues.
3 participants
@rullzer @MorrisJobke @icewind1991