Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use proper methods for display name retrieval #24318

Merged
merged 2 commits into from
Jun 17, 2021
Merged

Use proper methods for display name retrieval #24318

merged 2 commits into from
Jun 17, 2021

Conversation

MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Nov 23, 2020 •
edited
Loading

@MorrisJobke MorrisJobke added this to the Nextcloud 21 milestone Nov 23, 2020
blizzz
blizzz approved these changes Nov 23, 2020
View reviewed changes
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 30, 2020
@MorrisJobke
Copy link
Member Author

CI says no ... let me remove the DI part again as it causes a lot of trouble at other places :/

@MorrisJobke MorrisJobke added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Nov 30, 2020
This was referenced Dec 14, 2020
Merged
Merged
@ChristophWurst
Copy link
Member

tech dept and not fully one -> let's move to 22

@rullzer
Copy link
Member

rullzer commented Mar 30, 2021

Kill or continue?

@MorrisJobke
Copy link
Member Author

Kill or continue?

🔥 but the code and not the PR ... let me rebase and 🙏

splitt3r
splitt3r requested changes Apr 1, 2021
View reviewed changes
apps/files_sharing/lib/SharedStorage.php Outdated Show resolved Hide resolved
@MorrisJobke MorrisJobke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 1, 2021
@MorrisJobke MorrisJobke force-pushed the techdebt/noid/remove-oc_user-getDisplayName branch from b6d0274 to 22ed863 Compare April 1, 2021 20:48
@nextcloud nextcloud deleted a comment from faily-bot bot Apr 1, 2021
@MorrisJobke
Copy link
Member Author

Rebased.

@J0WI
Copy link
Contributor

J0WI commented Apr 28, 2021

PHPUnit is not happy

This was referenced May 20, 2021
Merged
Merged
@blizzz blizzz mentioned this pull request Jun 2, 2021
Merged
57 tasks
@MorrisJobke MorrisJobke mentioned this pull request Jun 10, 2021
Merged
59 tasks
@blizzz blizzz mentioned this pull request Jun 16, 2021
Merged
45 tasks
@blizzz
Copy link
Member

blizzz commented Jun 16, 2021

@MorrisJobke could you check the tests?

@MorrisJobke
Use proper methods for display name retrieval
0954184 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke
Use DI for files_sharing Cache
2690481 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke force-pushed the techdebt/noid/remove-oc_user-getDisplayName branch from 22ed863 to 2690481 Compare June 17, 2021 08:22
@MorrisJobke
Copy link
Member Author

@MorrisJobke could you check the tests?

Let's see if the latest change fixes it.

@ChristophWurst ChristophWurst merged commit b73f40e into master Jun 17, 2021
@ChristophWurst ChristophWurst deleted the techdebt/noid/remove-oc_user-getDisplayName branch June 17, 2021 16:17
@MorrisJobke MorrisJobke mentioned this pull request Jun 18, 2021
Closed
@blizzz blizzz mentioned this pull request Jun 23, 2021
Merged
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@splitt3r splitt3r splitt3r approved these changes

@blizzz blizzz blizzz approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

@kesselb kesselb Awaiting requested review from kesselb

Assignees
No one assigned
Labels
3. to review Waiting for reviews technical debt
Projects
None yet
Milestone
Nextcloud 22
Development

Successfully merging this pull request may close these issues.
7 participants
@MorrisJobke @ChristophWurst @rullzer @J0WI @blizzz @splitt3r @skjnldsv