-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure that getConfig is still called for browsers that do not support CSPv3 #22636
Conversation
…port CSPv3 Signed-off-by: Julius Härtl <jus@bitgrid.net>
/backport to stable19 |
Should fix cypress tests in text where this was causing the sharing sidebar to not show the share link button since the sharing sidebar was unable to determine if |
We should ideally separate the injected ones from the initial state, however this pr is keeping changes minimal for easier backporting. |
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 32730: failuremariadb10.4-php7.3Show full log
|
The backport to stable19 failed. Please do this backport manually. |
Backport in #22904 |
The `bugfix/noid/initial-stte-cspv3` branch has been merged into master in nextcloud/server#22636 . It does not exist anymore which will cause issues when trying to run the cypress tests. Remove the `$BRANCH` environment variable from the docker-compose.yml.
Fixes a regression from cbd2086 where browsers that do not support CSP v3 would not have initial state for config and capabilities provided. They are set in
server/lib/private/Template/JSConfigHelper.php
Lines 306 to 307 in 0209532