add option for delete external files without copy to trashbin

[dassio]

feature enhancement base on #18396 #14436

when deleting external files, the admin can choose using trashbin or not, default is using trashbin

[blizzz]

A problem with this addition is, that the end user likely does not know whether a file goes to the trashbin upon deletion, or not. It creates an inconsistency. If we accept it, then it should also be reflected to the end user, that deletion is permanent (@jancborchardt ?). In general i think it is a good addition – the default should be move to trashbin on the other hand, and the settings option positive, e.g. "[x] Deleted files are moved to trashbin".

[dassio]

A problem with this addition is, that the end user likely does not know whether a file goes to the trashbin upon deletion, or not. It creates an inconsistency. If we accept it, then it should also be reflected to the end user, that deletion is permanent (@jancborchardt ?). In general i think it is a good addition – the default should be move to trashbin on the other hand, and the settings option positive, e.g. "[x] Deleted files are moved to trashbin".

sorry about the confusing screenshot, in default mode, the checkbox is not selected

[dassio]

A problem with this addition is, that the end user likely does not know whether a file goes to the trashbin upon deletion, or not. It creates an inconsistency. If we accept it, then it should also be reflected to the end user

you mean like a popup when users delete files with this option on?

[icewind1991]

Code wise this looks good. I agree that there should be some indication to the user that the behaviour of deleting files from this specific storage is different than deleting other files

[blizzz]

A problem with this addition is, that the end user likely does not know whether a file goes to the trashbin upon deletion, or not. It creates an inconsistency. If we accept it, then it should also be reflected to the end user

you mean like a popup when users delete files with this option on?

Rather the the menu entry stating "Delete file permanently", perhaps turning it red, too.

but some indicator would be necessary for the batch action as well.

[dassio]

[dassio]

add alert for batch delete

[jancborchardt]

Really skeptical about this, sorry to say @dassio :(

As @blizzz said:

A problem with this addition is, that the end user likely does not know whether a file goes to the trashbin upon deletion, or not. It creates an inconsistency.

And it’s a real problem cause it’s basically a UX choice that is done by the admin, on a per-folder basis. So this not only creates confusion on a per-Nextcloud basis, but also per-folder.

---

So while I really tend to say let’s please not do it, I’d like to know which problem you want to solve @dassio – I’m sure we can find a different approach which fits with other requirements too. :)

[jancborchardt]

(Btw @dassio since you are doing a bunch of contributions: We have a Nextcloud Talk instance where we also invite contributors and have channels for general discussion and also the different apps. I can invite you for a guest account with your email address? :) Also let me know which apps you’d like to be in the channels of.)

[dassio]

So while I really tend to say let’s please not do it, I’d like to know which problem you want to solve @dassio – I’m sure we can find a different approach which fits with other requirements too. :)

except from the issues I linked( #18396 #14436), I am really concerned about the download traffic from S3, this one can add up to a big amount compared to what the storage I have to pay.

once I used the MAP app that to extract all the metadata(longitude and latitude ), I ended up downloading 500G from S3, paying 25+ dollars compared to 2 or 1 dollar I have to pay for the storage.

also before I used a Linode that is 20 dollars/ Month because the 10 dollar instance does not have enough disk space, then later I found it is the S3 deleted files that are eating up the disk, I pay an extra 10 dollars for another 5-10 months

[dassio]

And it’s a real problem cause it’s basically a UX choice that is done by the admin, on a per-folder basis. So this not only creates confusion on a per-Nextcloud basis, but also per-folder.

I see this one as a concrete requirement if I remember correctly, for the network-attached folder on windows, when you try to delete a file, Windows will not download to the trashbin

as for the inconsistency, if the functionality is not enabled, there will be no inconsistency issue, if it is enabled, that means the user really needs it. (i am a user, and I really need it ), we should not make the decision for the user by depriving them the possibility

Edit 1:
Deleting a file from a network drive

[dassio]

(Btw @dassio since you are doing a bunch of contributions: We have a Nextcloud Talk instance where we also invite contributors and have channels for general discussion and also the different apps. I can invite you for a guest account with your email address? :) Also let me know which apps you’d like to be in the channels of.)

that will be great, yes you can use my github email
I'd like to be in the photos and serve app

[juliusknorr]

@jancborchardt In addition to the points @dassio mentioned there is also the case where a file on an external storage is larger than the users quota available for trashbin. In that case the file will just be removed, since the user is not allowed to store so much data in there. Would need additional handling, but depending on the use case a flag might already solve issues here in most of the scenarios.

So 👍 from my side for this PR.

[jancborchardt]

Right, thanks for the explanation @juliushaertl. Then it sounds good – my only feedback is that the correct wording and capitalization would be "Deletion without trashbin".

[MorrisJobke]

Close at it was moved to #23489