Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added config setting to allow newly created users to be private. #22402

Closed
wants to merge 1 commit into from
Closed

Added config setting to allow newly created users to be private. #22402

wants to merge 1 commit into from

Conversation

clarg18
Copy link

@clarg18 clarg18 commented Aug 24, 2020

Hello,

Fixes issue: #14358

This is my first real commit to any project so all feedback welcome.

I added a new setting to the sample config file users_private_by_default such that a newly created user has all their setting scopes to private.

I did not see any existing function that changes the scope setting and the editUser seemed hardcoded to change the value so I added the logic to an if statement on the addUser method.

…s issue: 14358

Signed-off-by: Glen Clark <glenuk@gmail.com>
@kesselb
Copy link
Contributor

kesselb commented Aug 24, 2020

Thanks and welcome 👍

Looks similar to #20667

@clarg18
Copy link
Author

clarg18 commented Aug 24, 2020

Thanks and welcome 👍

Looks similar to #20667

Thank you @kesselb .

I see the other commit changed the AccountManager class. I considered doing that but did not want to introduce a new dependency there.

Should I close this PR?

@clarg18 clarg18 closed this Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants