Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use DOMContentLoaded and fix sharebymail loading issue #21921

Merged
merged 1 commit into from
Jul 20, 2020
Merged

Use DOMContentLoaded and fix sharebymail loading issue #21921

merged 1 commit into from
Jul 20, 2020

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jul 20, 2020 •
edited
Loading

After #20949

@skjnldsv
Use DOMContentLoaded and fix sharebymail loading issue
6fcd075 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the fix/use-DOMContentLoaded branch from 6a6c8bd to 6fcd075 Compare July 20, 2020 10:42
@skjnldsv skjnldsv self-assigned this Jul 20, 2020
@skjnldsv skjnldsv added this to the Nextcloud 20 milestone Jul 20, 2020
@npmbuildbot-nextcloud npmbuildbot-nextcloud bot force-pushed the fix/use-DOMContentLoaded branch from 6fcd075 to 52773e9 Compare July 20, 2020 10:43
@skjnldsv skjnldsv force-pushed the fix/use-DOMContentLoaded branch from 52773e9 to 6fcd075 Compare July 20, 2020 10:44
skjnldsv
skjnldsv commented Jul 20, 2020
View reviewed changes
apps/files_sharing/src/services/ConfigService.js
Comment on lines +181 to +185
const capabilities = OC.getCapabilities()
// eslint-disable-next-line camelcase
return capabilities?.files_sharing?.sharebymail !== undefined
// eslint-disable-next-line camelcase
&& capabilities?.files_sharing?.public?.enabled === true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For you @rullzer

@skjnldsv skjnldsv mentioned this pull request Jul 20, 2020
Merged
@skjnldsv
Copy link
Member Author

Failure unrelated :)
app-comments.feature

@ChristophWurst ChristophWurst mentioned this pull request Jul 20, 2020
Closed
juliusknorr
juliusknorr approved these changes Jul 20, 2020
View reviewed changes
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to do the trick with the random loading issues.

@skjnldsv skjnldsv merged commit 84ca586 into master Jul 20, 2020
@skjnldsv skjnldsv deleted the fix/use-DOMContentLoaded branch July 20, 2020 12:07
@MorrisJobke
Copy link
Member

Oh! This makes the integration tests more reliable! 🚀

@MorrisJobke MorrisJobke mentioned this pull request Aug 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgehrke georgehrke georgehrke approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@GretaD GretaD Awaiting requested review from GretaD

@gary-kim gary-kim Awaiting requested review from gary-kim

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug high javascript regression
Projects
None yet
Milestone
Nextcloud 20
Development

Successfully merging this pull request may close these issues.
4 participants
@skjnldsv @MorrisJobke @georgehrke @juliusknorr