Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes select2 in settings/admin look the same like everywhere else #209

Merged
merged 1 commit into from
Jun 26, 2016

Conversation

vincchan
Copy link
Member

Makes this:

screen shot 2016-06-23 at 12 38 18

look like this:

screen shot 2016-06-23 at 12 41 25

please review @nextcloud/designers thanks :)

@vincchan vincchan added bug design Design, UI, UX, etc. 3. to review Waiting for reviews labels Jun 23, 2016
@williambargent
Copy link
Member

I think the field should be the same height as before; other than that looks good.

@vincchan
Copy link
Member Author

vincchan commented Jun 23, 2016

@williambargent oh my bad, that is not the same select field in the screenshot. Height is still the same

screen shot 2016-06-23 at 12 57 27

@jancborchardt
Copy link
Member

@vincchan aaawesome! I wanted to do that since some time. Did you check it also works everywhere else we use select2, like the tags sidebar and the apps menu where you can restrict apps to specific groups?

@vincchan
Copy link
Member Author

vincchan commented Jun 23, 2016

@jancborchardt I don't see it anywhere else where it looks out of place, but if you want to make sure that every select2 is replaced with the css we could put the changes into a core css file where it is included in the template for sure

@williambargent
Copy link
Member

👍

@LukasReschke
Copy link
Member

LGTM. Awesome stuff 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants