Fix listing users in groups with slash in the name #18462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gary Kim <gary@garykim.dev>
| @@ -205,7 +205,7 @@ const actions = { | |||
| search = typeof search === 'string' ? search : '' | |||
| group = typeof group === 'string' ? group : '' | |||
| if (group !== '') { | |||
| return api.get(OC.linkToOCS(`cloud/groups/${group}/users/details?offset=${offset}&limit=${limit}&search=${search}`, 2)) | |||
| return api.get(OC.linkToOCS(`cloud/groups/${encodeURIComponent(group)}/users/details?offset=${offset}&limit=${limit}&search=${search}`, 2)) | |||
There was a problem hiding this comment.
on a related note: shouldn't we also encode search?
There was a problem hiding this comment.
It may be a good idea. For now, I believe the allowed characters in usernames means you shouldn't have a username with a character that needs to be encoded. I'll take a look when I've got a moment.
rullzer
approved these changes
Dec 18, 2019
This was referenced Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still had the groups with
/in the name from working on #18228 and noticed while messing with the users list that listing groups with/in the name also causes an error.This should fix that.