Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change primary button text color to white #1807

Merged
merged 1 commit into from
Oct 19, 2016
Merged

change primary button text color to white #1807

merged 1 commit into from
Oct 19, 2016

Conversation

jancborchardt
Copy link
Member

As mentioned by @irgendwie ;) Looks much nicer with the white arrow on the log in button and overall too.

Please review @nextcloud/designers

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@jancborchardt jancborchardt added bug design Design, UI, UX, etc. 3. to review Waiting for reviews labels Oct 19, 2016
@jancborchardt jancborchardt added this to the Nextcloud 11.0 milestone Oct 19, 2016
@mention-bot
Copy link

@jancborchardt, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Henni, @nickvergessen and @MorrisJobke to be potential reviewers.

@MariusBluem
Copy link
Member

Finally 👍

@irgendwie
Copy link
Member

LGTM 👍

@skjnldsv
Copy link
Member

Ahahah 👍

@MariusBluem MariusBluem merged commit 58d53eb into master Oct 19, 2016
@MariusBluem MariusBluem deleted the button-color branch October 19, 2016 19:08
@jancborchardt
Copy link
Member Author

YO! Don’t say »Finally« if you never opened an issue for it. ;D For any small thing you find, simply open an issue or directly fix it ;) 🎉

@MariusBluem
Copy link
Member

Someone had written in the forum or said it to me ... My fault 😅 ...People are telling me about soooo many of those papercuts every day 😜🙈

@jancborchardt
Copy link
Member Author

@MariusBluem I was joking ;D so whenever someone tells you about it, simply open an issue and we @nextcloud/designers can fix it! :)

@te-online
Copy link
Contributor

Very good 😊

Don't know if that's too much to ask, but would be cool to see screenshots of visual changes 🙈
Also makes it easier to review, whether it looks like it's supposed to look.

@jancborchardt
Copy link
Member Author

@te-online yeah, normally I always do that. Screenshots are useful! :)

@Espina2
Copy link
Contributor

Espina2 commented Oct 20, 2016

I already comment in another issue that its difficult to see design related issues if we don't have print screen's. :)

@jancborchardt
Copy link
Member Author

@Espina2 @te-online sure – but folks please do not forget that this whole design thing is not only about interface and graphics but about the whole UX and interaction. So running a local development environment to test it is pretty important too. ;)

@te-online
Copy link
Contributor

@jancborchardt Sure! But then my second argument kicks in: You can't check if something is looking as expected, if you don't know what it's supposed to look like 😜

@jancborchardt
Copy link
Member Author

Of course, all true. :) Just wanna make sure that we don’t only judge improvements by reading the text and looking at images, but also on how it actually works. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants