-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change primary button text color to white #1807
Conversation
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@jancborchardt, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Henni, @nickvergessen and @MorrisJobke to be potential reviewers. |
Finally 👍 |
LGTM 👍 |
Ahahah 👍 |
YO! Don’t say »Finally« if you never opened an issue for it. ;D For any small thing you find, simply open an issue or directly fix it ;) 🎉 |
Someone had written in the forum or said it to me ... My fault 😅 ...People are telling me about soooo many of those papercuts every day 😜🙈 |
@MariusBluem I was joking ;D so whenever someone tells you about it, simply open an issue and we @nextcloud/designers can fix it! :) |
Very good 😊 Don't know if that's too much to ask, but would be cool to see screenshots of visual changes 🙈 |
@te-online yeah, normally I always do that. Screenshots are useful! :) |
I already comment in another issue that its difficult to see design related issues if we don't have print screen's. :) |
@Espina2 @te-online sure – but folks please do not forget that this whole design thing is not only about interface and graphics but about the whole UX and interaction. So running a local development environment to test it is pretty important too. ;) |
@jancborchardt Sure! But then my second argument kicks in: You can't check if something is looking as expected, if you don't know what it's supposed to look like 😜 |
Of course, all true. :) Just wanna make sure that we don’t only judge improvements by reading the text and looking at images, but also on how it actually works. :) |
As mentioned by @irgendwie ;) Looks much nicer with the white arrow on the log in button and overall too.
Please review @nextcloud/designers